Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable a bunch of debuginfo tests. #53154

Conversation

michaelwoerister
Copy link
Member

@michaelwoerister michaelwoerister commented Aug 7, 2018

Re-enable some more debuginfo tests that actually seem to work.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 7, 2018
@rust-highfive

This comment has been minimized.

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2018
@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 7, 2018
@michaelwoerister
Copy link
Member Author

Seems to work now.

r? @kennytm

@@ -40,14 +39,15 @@
// gdbr-check:$6 = core::option::Option::None

// gdb-command: print os_string
// gdb-check:$7 = "IAMA OS string 😃"
// gdb-check:$7 = "IAMA OS string"
Copy link
Member

@kennytm kennytm Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the emoji essential? #42278 (comment) mentioned something about Unicode.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's essential. In my terminal emulator this prints as the emoji, but on CI it seems to print escaped to octals. I did not find a quick way to make print the same everywhere, so I figured that it's better to have a test for the simple case instead of none at all.

@kennytm
Copy link
Member

kennytm commented Aug 7, 2018

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 7, 2018

📌 Commit 4eb52ff has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2018
cramertj added a commit to cramertj/rust that referenced this pull request Aug 8, 2018
…ginfo-tests, r=kennytm

Re-enable a bunch of debuginfo tests.

Re-enable some more debuginfo tests that actually seem to work.
cramertj added a commit to cramertj/rust that referenced this pull request Aug 8, 2018
…ginfo-tests, r=kennytm

Re-enable a bunch of debuginfo tests.

Re-enable some more debuginfo tests that actually seem to work.
cramertj added a commit to cramertj/rust that referenced this pull request Aug 8, 2018
…ginfo-tests, r=kennytm

Re-enable a bunch of debuginfo tests.

Re-enable some more debuginfo tests that actually seem to work.
cramertj added a commit to cramertj/rust that referenced this pull request Aug 8, 2018
…ginfo-tests, r=kennytm

Re-enable a bunch of debuginfo tests.

Re-enable some more debuginfo tests that actually seem to work.
@cramertj
Copy link
Member

cramertj commented Aug 8, 2018

This seems to have caused test failures in rollup #53206: see https://ci.appveyor.com/project/rust-lang/rust/build/1.0.8503/job/nw74idt1w1skyomw:

Logs
failures:
---- [debuginfo-gdb] debuginfo\by-value-non-immediate-argument.rs stdout ----
NOTE: compiletest thinks it is using GDB without native rust support
NOTE: compiletest thinks it is using GDB version 7010001
error: line not found in debugger output: $5 = {__0 = 7, __1 = 8, __2 = 9.5, __3 = 10.5}
status: exit code: 0
command: PATH="C:\projects\rust\build\x86_64-pc-windows-gnu\stage2\lib\rustlib\x86_64-pc-windows-gnu\lib;C:\projects\rust\build\x86_64-pc-windows-gnu\llvm\build\bin;C:\projects\rust\build\x86_64-pc-windows-gnu\stage0-bootstrap-tools\x86_64-pc-windows-gnu\release\deps;C:\projects\rust\build\x86_64-pc-windows-gnu\stage0\bin;C:\Program Files (x86)\Inno Setup 5;C:\Python27;C:\projects\rust\mingw64\bin;C:\msys64\usr\bin;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\Perl\site\bin;C:\Perl\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Program Files\7-Zip;C:\Program Files\Microsoft\Web Platform Installer;C:\Tools\GitVersion;C:\Tools\PsTools;C:\Program Files\Git LFS;C:\Program Files (x86)\Subversion\bin;C:\Program Files\Microsoft SQL Server\120\Tools\Binn;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\110\Tools\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\Tools\Binn;C:\Program Files\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\Tools\Binn\ManagementStudio;C:\Tools\WebDriver;C:\Program Files (x86)\Microsoft SDKs\TypeScript\1.4;C:\Program Files (x86)\Microsoft Visual Studio 12.0\Common7\IDE\PrivateAssemblies;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI\wbin;C:\Ruby193\bin;C:\Tools\NUnit\bin;C:\Tools\xUnit;C:\Tools\MSpec;C:\Tools\Coverity\bin;C:\Program Files (x86)\CMake\bin;C:\go\bin;C:\Program Files\Java\jdk1.8.0\bin;C:\Python27;C:\Program Files\nodejs;C:\Program Files (x86)\iojs;C:\Program Files\iojs;C:\Users\appveyor\AppData\Roaming\npm;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files (x86)\MSBuild\14.0\Bin;C:\Tools\NuGet;C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\CommonExtensions\Microsoft\TestWindow;C:\Program Files\Microsoft DNX\Dnvm;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\130\Tools\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\Tools\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Apache\Maven\bin;C:\Python27\Scripts;C:\Tools\NUnit3;C:\Program Files\Mercurial;C:\Program Files\dotnet;C:\Tools\curl\bin;C:\Program Files\Amazon\AWSCLI;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn;C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\Extensions\Microsoft\SQLDB\DAC\140;C:\Tools\vcpkg;C:\Program Files (x86)\Microsoft SQL Server\140\Tools\Binn;C:\Program Files\Microsoft SQL Server\140\Tools\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\erl9.2\bin;C:\Program Files (x86)\Yarn\bin;C:\Program Files (x86)\NSIS;C:\Tools\Octopus;C:\Program Files\PowerShell\6.0.2;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\LLVM\bin;C:\Program Files\Git\cmd;C:\Program Files\Git\usr\bin;C:\ProgramData\chocolatey\bin;C:\Program Files (x86)\nodejs;C:\Users\appveyor\AppData\Local\Yarn\bin;C:\Users\appveyor\.dotnet\tools;C:\Users\appveyor\AppData\Roaming\npm;C:\Program Files\AppVeyor\BuildAgent;C:\projects\rust;C:\projects\rust\handle" "C:\\projects\\rust\\mingw64\\bin\\gdb" "-quiet" "-batch" "-nx" "-command=C:\\projects\\rust\\build\\x86_64-pc-windows-gnu\\test\\debuginfo\\by-value-non-immediate-argument\\by-value-non-immediate-argument.debugger.script"
stdout:
------------------------------------------
GNU gdb (GDB) 7.10.1
Copyright (C) 2015 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-w64-mingw32".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word".
Breakpoint 1 at 0x40161f: file C:\projects\rust\src/test\debuginfo\by-value-non-immediate-argument.rs, line 94.
Breakpoint 2 at 0x40165b: file C:\projects\rust\src/test\debuginfo\by-value-non-immediate-argument.rs, line 98.
Breakpoint 3 at 0x401674: file C:\projects\rust\src/test\debuginfo\by-value-non-immediate-argument.rs, line 102.
Breakpoint 4 at 0x401684: file C:\projects\rust\src/test\debuginfo\by-value-non-immediate-argument.rs, line 108.
Breakpoint 5 at 0x401694: file C:\projects\rust\src/test\debuginfo\by-value-non-immediate-argument.rs, line 120.
[New Thread 3308.0xe14]
Breakpoint 1, by_value_non_immediate_argument::fun::h5655355dea57288f (s=...) at C:\projects\rust\src/test\debuginfo\by-value-non-immediate-argument.rs:94
94	    zzz(); // #break
$1 = {a = 1, b = 2.5}
Breakpoint 2, by_value_non_immediate_argument::fun_fun::hebfe7f6888071e13 () at C:\projects\rust\src/test\debuginfo\by-value-non-immediate-argument.rs:98
98	    zzz(); // #break
$2 = {a = 3, b = 4.5}
$3 = 5
$4 = 6.5
Breakpoint 3, by_value_non_immediate_argument::tup::hb447d1a1503f7364 () at C:\projects\rust\src/test\debuginfo\by-value-non-immediate-argument.rs:102
102	    zzz(); // #break
------------------------------------------
stderr:
------------------------------------------
Warning: C:projectsrust./src/etc: No such file or directory.
warning: SHIMVIEW: ShimInfo(Complete)
C:\projects\rust\build\x86_64-pc-windows-gnu\test\debuginfo\by-value-non-immediate-argument\by-value-non-immediate-argument.debugger.script:19: Error in sourced command file:
No symbol "a" in current context.
------------------------------------------
thread '[debuginfo-gdb] debuginfo\by-value-non-immediate-argument.rs' panicked at 'explicit panic', tools\compiletest\src\runtest.rs:3149:9
note: Run with `RUST_BACKTRACE=1` for a backtrace.
---- [debuginfo-gdb] debuginfo\function-arg-initialization.rs stdout ----
NOTE: compiletest thinks it is using GDB without native rust support
NOTE: compiletest thinks it is using GDB version 7010001
error: line not found in debugger output: $4 = {a = 3, b = 4, c = 5, d = 6, e = 7, f = 8, g = 9, h = 10}
status: exit code: 0
command: PATH="C:\projects\rust\build\x86_64-pc-windows-gnu\stage2\lib\rustlib\x86_64-pc-windows-gnu\lib;C:\projects\rust\build\x86_64-pc-windows-gnu\llvm\build\bin;C:\projects\rust\build\x86_64-pc-windows-gnu\stage0-bootstrap-tools\x86_64-pc-windows-gnu\release\deps;C:\projects\rust\build\x86_64-pc-windows-gnu\stage0\bin;C:\Program Files (x86)\Inno Setup 5;C:\Python27;C:\projects\rust\mingw64\bin;C:\msys64\usr\bin;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\Perl\site\bin;C:\Perl\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Program Files\7-Zip;C:\Program Files\Microsoft\Web Platform Installer;C:\Tools\GitVersion;C:\Tools\PsTools;C:\Program Files\Git LFS;C:\Program Files (x86)\Subversion\bin;C:\Program Files\Microsoft SQL Server\120\Tools\Binn;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\110\Tools\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\Tools\Binn;C:\Program Files\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\Tools\Binn\ManagementStudio;C:\Tools\WebDriver;C:\Program Files (x86)\Microsoft SDKs\TypeScript\1.4;C:\Program Files (x86)\Microsoft Visual Studio 12.0\Common7\IDE\PrivateAssemblies;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI\wbin;C:\Ruby193\bin;C:\Tools\NUnit\bin;C:\Tools\xUnit;C:\Tools\MSpec;C:\Tools\Coverity\bin;C:\Program Files (x86)\CMake\bin;C:\go\bin;C:\Program Files\Java\jdk1.8.0\bin;C:\Python27;C:\Program Files\nodejs;C:\Program Files (x86)\iojs;C:\Program Files\iojs;C:\Users\appveyor\AppData\Roaming\npm;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files (x86)\MSBuild\14.0\Bin;C:\Tools\NuGet;C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\CommonExtensions\Microsoft\TestWindow;C:\Program Files\Microsoft DNX\Dnvm;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\130\Tools\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\Tools\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Apache\Maven\bin;C:\Python27\Scripts;C:\Tools\NUnit3;C:\Program Files\Mercurial;C:\Program Files\dotnet;C:\Tools\curl\bin;C:\Program Files\Amazon\AWSCLI;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn;C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\Extensions\Microsoft\SQLDB\DAC\140;C:\Tools\vcpkg;C:\Program Files (x86)\Microsoft SQL Server\140\Tools\Binn;C:\Program Files\Microsoft SQL Server\140\Tools\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\erl9.2\bin;C:\Program Files (x86)\Yarn\bin;C:\Program Files (x86)\NSIS;C:\Tools\Octopus;C:\Program Files\PowerShell\6.0.2;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\LLVM\bin;C:\Program Files\Git\cmd;C:\Program Files\Git\usr\bin;C:\ProgramData\chocolatey\bin;C:\Program Files (x86)\nodejs;C:\Users\appveyor\AppData\Local\Yarn\bin;C:\Users\appveyor\.dotnet\tools;C:\Users\appveyor\AppData\Roaming\npm;C:\Program Files\AppVeyor\BuildAgent;C:\projects\rust;C:\projects\rust\handle" "C:\\projects\\rust\\mingw64\\bin\\gdb" "-quiet" "-batch" "-nx" "-command=C:\\projects\\rust\\build\\x86_64-pc-windows-gnu\\test\\debuginfo\\function-arg-initialization\\function-arg-initialization.debugger.script"
stdout:
------------------------------------------
GNU gdb (GDB) 7.10.1
Copyright (C) 2015 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-w64-mingw32".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word".
Breakpoint 1 at 0x401556: file C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs, line 234.
Breakpoint 2 at 0x401574: file C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs, line 249.
Breakpoint 3 at 0x4015b1: file C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs, line 253.
Breakpoint 4 at 0x401621: file C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs, line 258.
Breakpoint 5 at 0x401674: file C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs, line 263.
Breakpoint 6 at 0x401693: file C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs, line 267.
Breakpoint 7 at 0x4016b3: file C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs, line 271.
Breakpoint 8 at 0x4016d4: file C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs, line 275.
Breakpoint 9 at 0x401724: file C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs, line 279.
Breakpoint 10 at 0x401793: file C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs, line 287.
Breakpoint 11 at 0x401823: file C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs, line 295.
[New Thread 1120.0x1330]
Breakpoint 1, function_arg_initialization::immediate_args::h4b590aedb652992c (a=1, b=true, c=2.5) at C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs:234
234	    zzz(); // #break
$1 = 1
$2 = true
$3 = 2.5
Breakpoint 2, function_arg_initialization::non_immediate_args::hae8b42f5983dc5c0 () at C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs:249
249	    zzz(); // #break
------------------------------------------
stderr:
------------------------------------------
Warning: C:projectsrust./src/etc: No such file or directory.
warning: SHIMVIEW: ShimInfo(Complete)
C:\projects\rust\build\x86_64-pc-windows-gnu\test\debuginfo\function-arg-initialization\function-arg-initialization.debugger.script:23: Error in sourced command file:
No symbol "a" in current context.
------------------------------------------
thread '[debuginfo-gdb] debuginfo\function-arg-initialization.rs' panicked at 'explicit panic', tools\compiletest\src\runtest.rs:3149:9
failures:
    [debuginfo-gdb] debuginfo\by-value-non-immediate-argument.rs
    [debuginfo-gdb] debuginfo\function-arg-initialization.rs
test result: FAILED. 81 passed; 2 failed; 26 ignored; 0 measured; 0 filtered out
thread 'main' panicked at 'Some tests failed', tools\compiletest\src\main.rs:497:22
command did not execute successfully: "C:\\projects\\rust\\build\\x86_64-pc-windows-gnu\\stage0-tools-bin\\compiletest.exe" "--compile-lib-path" "C:\\projects\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin" "--run-lib-path" "C:\\projects\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\lib\\rustlib\\x86_64-pc-windows-gnu\\lib" "--rustc-path" "C:\\projects\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "--src-base" "C:\\projects\\rust\\src/test\\debuginfo" "--build-base" "C:\\projects\\rust\\build\\x86_64-pc-windows-gnu\\test\\debuginfo" "--stage-id" "stage2-x86_64-pc-windows-gnu" "--mode" "debuginfo-gdb" "--target" "x86_64-pc-windows-gnu" "--host" "x86_64-pc-windows-gnu" "--llvm-filecheck" "C:\\projects\\rust\\build\\x86_64-pc-windows-gnu\\llvm\\build\\bin\\FileCheck.exe" "--nodejs" "C:\\Program Files (x86)\\nodejs\\node" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=C:\\projects\\rust\\build\\x86_64-pc-windows-gnu\\native\\rust-test-helpers" "--docck-python" "C:\\Python27\\python.exe" "--lldb-python" "C:\\Python27\\python.exe" "--gdb" "C:\\projects\\rust\\mingw64\\bin\\gdb" "--lldb-version" "lldb version 6.0.0" "--lldb-python-dir" "<COULD NOT FIND PATH>" "--llvm-version" "7.0.0\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
expected success, got: exit code: 101
failed to run: C:\projects\rust\build\bootstrap\debug\bootstrap test

@kennytm
Copy link
Member

kennytm commented Aug 9, 2018

@bors rollup-

@bors
Copy link
Contributor

bors commented Aug 10, 2018

⌛ Testing commit 4eb52ff with merge 97e096691801785e730dd1e1dcae26f4dc29c538...

@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 10, 2018
@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2018
@kennytm
Copy link
Member

kennytm commented Aug 10, 2018

x86_64-mingw:

[01:01:08] failures:
[01:01:08] 
[01:01:08] ---- [debuginfo-gdb] debuginfo\by-value-non-immediate-argument.rs stdout ----
[01:01:08] NOTE: compiletest thinks it is using GDB without native rust support
[01:01:08] NOTE: compiletest thinks it is using GDB version 7010001
[01:01:08] 
[01:01:08] error: line not found in debugger output: $5 = {__0 = 7, __1 = 8, __2 = 9.5, __3 = 10.5}
[01:01:08] status: exit code: 0
[01:01:08] command: PATH="C:\projects\rust\build\x86_64-pc-windows-gnu\stage2\lib\rustlib\x86_64-pc-windows-gnu\lib;C:\projects\rust\build\x86_64-pc-windows-gnu\llvm\build\bin;C:\projects\rust\build\x86_64-pc-windows-gnu\stage0-bootstrap-tools\x86_64-pc-windows-gnu\release\deps;C:\projects\rust\build\x86_64-pc-windows-gnu\stage0\bin;C:\Program Files (x86)\Inno Setup 5;C:\Python27;C:\projects\rust\mingw64\bin;C:\msys64\usr\bin;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\Perl\site\bin;C:\Perl\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Program Files\7-Zip;C:\Program Files\Microsoft\Web Platform Installer;C:\Tools\GitVersion;C:\Tools\PsTools;C:\Program Files\Git LFS;C:\Program Files (x86)\Subversion\bin;C:\Program Files\Microsoft SQL Server\120\Tools\Binn;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\110\Tools\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\Tools\Binn;C:\Program Files\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\Tools\Binn\ManagementStudio;C:\Tools\WebDriver;C:\Program Files (x86)\Microsoft SDKs\TypeScript\1.4;C:\Program Files (x86)\Microsoft Visual Studio 12.0\Common7\IDE\PrivateAssemblies;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI\wbin;C:\Ruby193\bin;C:\Tools\NUnit\bin;C:\Tools\xUnit;C:\Tools\MSpec;C:\Tools\Coverity\bin;C:\Program Files (x86)\CMake\bin;C:\go\bin;C:\Program Files\Java\jdk1.8.0\bin;C:\Python27;C:\Program Files\nodejs;C:\Program Files (x86)\iojs;C:\Program Files\iojs;C:\Users\appveyor\AppData\Roaming\npm;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files (x86)\MSBuild\14.0\Bin;C:\Tools\NuGet;C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\CommonExtensions\Microsoft\TestWindow;C:\Program Files\Microsoft DNX\Dnvm;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\130\Tools\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\Tools\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Apache\Maven\bin;C:\Python27\Scripts;C:\Tools\NUnit3;C:\Program Files\Mercurial;C:\Program Files\dotnet;C:\Tools\curl\bin;C:\Program Files\Amazon\AWSCLI;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn;C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\Extensions\Microsoft\SQLDB\DAC\140;C:\Tools\vcpkg;C:\Program Files (x86)\Microsoft SQL Server\140\Tools\Binn;C:\Program Files\Microsoft SQL Server\140\Tools\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\erl9.2\bin;C:\Program Files (x86)\Yarn\bin;C:\Program Files (x86)\NSIS;C:\Tools\Octopus;C:\Program Files\PowerShell\6.0.2;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\LLVM\bin;C:\Program Files\Git\cmd;C:\Program Files\Git\usr\bin;C:\ProgramData\chocolatey\bin;C:\Program Files (x86)\nodejs;C:\Users\appveyor\AppData\Local\Yarn\bin;C:\Users\appveyor\.dotnet\tools;C:\Users\appveyor\AppData\Roaming\npm;C:\Program Files\AppVeyor\BuildAgent;C:\projects\rust;C:\projects\rust\handle" "C:\\projects\\rust\\mingw64\\bin\\gdb" "-quiet" "-batch" "-nx" "-command=C:\\projects\\rust\\build\\x86_64-pc-windows-gnu\\test\\debuginfo\\by-value-non-immediate-argument\\by-value-non-immediate-argument.debugger.script"
[01:01:08] stdout:
[01:01:08] ------------------------------------------
[01:01:08] GNU gdb (GDB) 7.10.1
[01:01:08] Copyright (C) 2015 Free Software Foundation, Inc.
[01:01:08] License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
[01:01:08] This is free software: you are free to change and redistribute it.
[01:01:08] There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
[01:01:08] and "show warranty" for details.
[01:01:08] This GDB was configured as "x86_64-w64-mingw32".
[01:01:08] Type "show configuration" for configuration details.
[01:01:08] For bug reporting instructions, please see:
[01:01:08] <http://www.gnu.org/software/gdb/bugs/>.
[01:01:08] Find the GDB manual and other documentation resources online at:
[01:01:08] <http://www.gnu.org/software/gdb/documentation/>.
[01:01:08] For help, type "help".
[01:01:08] Type "apropos word" to search for commands related to "word".
[01:01:08] Breakpoint 1 at 0x40161f: file C:\projects\rust\src/test\debuginfo\by-value-non-immediate-argument.rs, line 94.
[01:01:08] Breakpoint 2 at 0x40165b: file C:\projects\rust\src/test\debuginfo\by-value-non-immediate-argument.rs, line 98.
[01:01:08] Breakpoint 3 at 0x401674: file C:\projects\rust\src/test\debuginfo\by-value-non-immediate-argument.rs, line 102.
[01:01:08] Breakpoint 4 at 0x401684: file C:\projects\rust\src/test\debuginfo\by-value-non-immediate-argument.rs, line 108.
[01:01:08] Breakpoint 5 at 0x401694: file C:\projects\rust\src/test\debuginfo\by-value-non-immediate-argument.rs, line 120.
[01:01:08] [New Thread 2952.0x1128]
[01:01:08] 
[01:01:08] Breakpoint 1, by_value_non_immediate_argument::fun::h5655355dea57288f (s=...) at C:\projects\rust\src/test\debuginfo\by-value-non-immediate-argument.rs:94
[01:01:08] 94	    zzz(); // #break
[01:01:08] $1 = {a = 1, b = 2.5}
[01:01:08] 
[01:01:08] Breakpoint 2, by_value_non_immediate_argument::fun_fun::hebfe7f6888071e13 () at C:\projects\rust\src/test\debuginfo\by-value-non-immediate-argument.rs:98
[01:01:08] 98	    zzz(); // #break
[01:01:08] $2 = {a = 3, b = 4.5}
[01:01:08] $3 = 5
[01:01:08] $4 = 6.5
[01:01:08] 
[01:01:08] Breakpoint 3, by_value_non_immediate_argument::tup::hb447d1a1503f7364 () at C:\projects\rust\src/test\debuginfo\by-value-non-immediate-argument.rs:102
[01:01:08] 102	    zzz(); // #break
[01:01:08] 
[01:01:08] ------------------------------------------
[01:01:08] stderr:
[01:01:08] ------------------------------------------
[01:01:08] Warning: C:projectsrust./src/etc: No such file or directory.
[01:01:08] warning: SHIMVIEW: ShimInfo(Complete)

[01:01:08] C:\projects\rust\build\x86_64-pc-windows-gnu\test\debuginfo\by-value-non-immediate-argument\by-value-non-immediate-argument.debugger.script:19: Error in sourced command file:
[01:01:08] No symbol "a" in current context.
[01:01:08] 
[01:01:08] ------------------------------------------
[01:01:08] 
[01:01:08] thread '[debuginfo-gdb] debuginfo\by-value-non-immediate-argument.rs' panicked at 'explicit panic', tools\compiletest\src\runtest.rs:3149:9
[01:01:08] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:01:08] 
[01:01:08] ---- [debuginfo-gdb] debuginfo\function-arg-initialization.rs stdout ----
[01:01:08] NOTE: compiletest thinks it is using GDB without native rust support
[01:01:08] NOTE: compiletest thinks it is using GDB version 7010001
[01:01:08] 
[01:01:08] error: line not found in debugger output: $4 = {a = 3, b = 4, c = 5, d = 6, e = 7, f = 8, g = 9, h = 10}
[01:01:08] status: exit code: 0
[01:01:08] command: PATH="C:\projects\rust\build\x86_64-pc-windows-gnu\stage2\lib\rustlib\x86_64-pc-windows-gnu\lib;C:\projects\rust\build\x86_64-pc-windows-gnu\llvm\build\bin;C:\projects\rust\build\x86_64-pc-windows-gnu\stage0-bootstrap-tools\x86_64-pc-windows-gnu\release\deps;C:\projects\rust\build\x86_64-pc-windows-gnu\stage0\bin;C:\Program Files (x86)\Inno Setup 5;C:\Python27;C:\projects\rust\mingw64\bin;C:\msys64\usr\bin;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\Perl\site\bin;C:\Perl\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Program Files\7-Zip;C:\Program Files\Microsoft\Web Platform Installer;C:\Tools\GitVersion;C:\Tools\PsTools;C:\Program Files\Git LFS;C:\Program Files (x86)\Subversion\bin;C:\Program Files\Microsoft SQL Server\120\Tools\Binn;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\110\Tools\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\Tools\Binn;C:\Program Files\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\Tools\Binn\ManagementStudio;C:\Tools\WebDriver;C:\Program Files (x86)\Microsoft SDKs\TypeScript\1.4;C:\Program Files (x86)\Microsoft Visual Studio 12.0\Common7\IDE\PrivateAssemblies;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI\wbin;C:\Ruby193\bin;C:\Tools\NUnit\bin;C:\Tools\xUnit;C:\Tools\MSpec;C:\Tools\Coverity\bin;C:\Program Files (x86)\CMake\bin;C:\go\bin;C:\Program Files\Java\jdk1.8.0\bin;C:\Python27;C:\Program Files\nodejs;C:\Program Files (x86)\iojs;C:\Program Files\iojs;C:\Users\appveyor\AppData\Roaming\npm;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files (x86)\MSBuild\14.0\Bin;C:\Tools\NuGet;C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\CommonExtensions\Microsoft\TestWindow;C:\Program Files\Microsoft DNX\Dnvm;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\130\Tools\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\Tools\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn;C:\Program Files\Microsoft SQL Server\130\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Apache\Maven\bin;C:\Python27\Scripts;C:\Tools\NUnit3;C:\Program Files\Mercurial;C:\Program Files\dotnet;C:\Tools\curl\bin;C:\Program Files\Amazon\AWSCLI;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn;C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\Extensions\Microsoft\SQLDB\DAC\140;C:\Tools\vcpkg;C:\Program Files (x86)\Microsoft SQL Server\140\Tools\Binn;C:\Program Files\Microsoft SQL Server\140\Tools\Binn;C:\Program Files\Microsoft SQL Server\140\DTS\Binn;C:\Program Files\erl9.2\bin;C:\Program Files (x86)\Yarn\bin;C:\Program Files (x86)\NSIS;C:\Tools\Octopus;C:\Program Files\PowerShell\6.0.2;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\LLVM\bin;C:\Program Files\Git\cmd;C:\Program Files\Git\usr\bin;C:\ProgramData\chocolatey\bin;C:\Program Files (x86)\nodejs;C:\Users\appveyor\AppData\Local\Yarn\bin;C:\Users\appveyor\.dotnet\tools;C:\Users\appveyor\AppData\Roaming\npm;C:\Program Files\AppVeyor\BuildAgent;C:\projects\rust;C:\projects\rust\handle" "C:\\projects\\rust\\mingw64\\bin\\gdb" "-quiet" "-batch" "-nx" "-command=C:\\projects\\rust\\build\\x86_64-pc-windows-gnu\\test\\debuginfo\\function-arg-initialization\\function-arg-initialization.debugger.script"
[01:01:08] stdout:
[01:01:08] ------------------------------------------
[01:01:08] GNU gdb (GDB) 7.10.1
[01:01:08] Copyright (C) 2015 Free Software Foundation, Inc.
[01:01:08] License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
[01:01:08] This is free software: you are free to change and redistribute it.
[01:01:08] There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
[01:01:08] and "show warranty" for details.
[01:01:08] This GDB was configured as "x86_64-w64-mingw32".
[01:01:08] Type "show configuration" for configuration details.
[01:01:08] For bug reporting instructions, please see:
[01:01:08] <http://www.gnu.org/software/gdb/bugs/>.
[01:01:08] Find the GDB manual and other documentation resources online at:
[01:01:08] <http://www.gnu.org/software/gdb/documentation/>.
[01:01:08] For help, type "help".
[01:01:08] Type "apropos word" to search for commands related to "word".
[01:01:08] Breakpoint 1 at 0x401556: file C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs, line 234.
[01:01:08] Breakpoint 2 at 0x401574: file C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs, line 249.
[01:01:08] Breakpoint 3 at 0x4015b1: file C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs, line 253.
[01:01:08] Breakpoint 4 at 0x401621: file C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs, line 258.
[01:01:08] Breakpoint 5 at 0x401674: file C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs, line 263.
[01:01:08] Breakpoint 6 at 0x401693: file C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs, line 267.
[01:01:08] Breakpoint 7 at 0x4016b3: file C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs, line 271.
[01:01:08] Breakpoint 8 at 0x4016d4: file C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs, line 275.
[01:01:08] Breakpoint 9 at 0x401724: file C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs, line 279.
[01:01:08] Breakpoint 10 at 0x401793: file C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs, line 287.
[01:01:08] Breakpoint 11 at 0x401823: file C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs, line 295.
[01:01:08] [New Thread 4352.0xedc]
[01:01:08] 
[01:01:08] Breakpoint 1, function_arg_initialization::immediate_args::h4b590aedb652992c (a=1, b=true, c=2.5) at C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs:234
[01:01:08] 234	    zzz(); // #break
[01:01:08] $1 = 1
[01:01:08] $2 = true
[01:01:08] $3 = 2.5
[01:01:08] 
[01:01:08] Breakpoint 2, function_arg_initialization::non_immediate_args::hae8b42f5983dc5c0 () at C:\projects\rust\src/test\debuginfo\function-arg-initialization.rs:249
[01:01:08] 249	    zzz(); // #break
[01:01:08] 
[01:01:08] ------------------------------------------
[01:01:08] stderr:
[01:01:08] ------------------------------------------
[01:01:08] Warning: C:projectsrust./src/etc: No such file or directory.
[01:01:08] warning: SHIMVIEW: ShimInfo(Complete)

[01:01:08] C:\projects\rust\build\x86_64-pc-windows-gnu\test\debuginfo\function-arg-initialization\function-arg-initialization.debugger.script:23: Error in sourced command file:
[01:01:08] No symbol "a" in current context.
[01:01:08] 
[01:01:08] ------------------------------------------
[01:01:08] 
[01:01:08] thread '[debuginfo-gdb] debuginfo\function-arg-initialization.rs' panicked at 'explicit panic', tools\compiletest\src\runtest.rs:3149:9
[01:01:08] 
[01:01:08] 
[01:01:08] failures:
[01:01:08]     [debuginfo-gdb] debuginfo\by-value-non-immediate-argument.rs
[01:01:08]     [debuginfo-gdb] debuginfo\function-arg-initialization.rs
[01:01:08] 
[01:01:08] test result: FAILED. 81 passed; 2 failed; 26 ignored; 0 measured; 0 filtered out

@michaelwoerister
Copy link
Member Author

GDB has always been flaky on Windows. Let's not let that prevent us from testing on other platforms.

@kennytm
Copy link
Member

kennytm commented Aug 13, 2018

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 13, 2018

📌 Commit 5dd8ed0 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 13, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Aug 13, 2018
…ginfo-tests, r=kennytm

Re-enable a bunch of debuginfo tests.

Re-enable some more debuginfo tests that actually seem to work.
@michaelwoerister
Copy link
Member Author

Adding this to a rollup is risky business ;)

@kennytm
Copy link
Member

kennytm commented Aug 14, 2018

heh.

@bors rollup- r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 14, 2018
@XAMPPRocky
Copy link
Member

Triage: @kennytm What is left to be done with this PR?

@kennytm
Copy link
Member

kennytm commented Aug 21, 2018

@Aaronepower The reenabled tests caused #53309 (comment) to fail and must be fixed before approving again.

@XAMPPRocky XAMPPRocky added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 21, 2018
@Dylan-DPC-zz
Copy link

ping from triage @kennytm @michaelwoerister what's the update on this?

@michaelwoerister
Copy link
Member Author

I don't really have time to look into this :/ Closing.

@Dylan-DPC-zz Dylan-DPC-zz added S-blocked-closed and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Nov 27, 2018
@jyn514 jyn514 added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-blocked-closed labels Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants